Thanks for the feedback @GaborDicsoMidori
We have decided to go with this approach because:
As for the linter warning, we have opted to add a generic warning that gets displayed as soon as you are using a dynamic properties module. The warning cannot be fixed (via the usual
lint --fix) so it will always be displayed as a reminder.
We have opted with this approach because there was too many combinations of how to define an icon property in an app code, and the linter would have not necessarily picked all those combinations.
As explained on this thread: New permission checks for dynamic properties - #2 by XavierCaron
With your feedback, and the fact that indeed, the documentation has been updated, we can remove it in the next CLI release. The main concern we had was people not knowing that they needed to change their permissions for existing Forge apps with dynamic properties modules.
Cheers,
Xavier