Thanks! Yea, we were able to mitigate the issue by rolling back a recent deployment however as a consequence some recent token changes we were running as an experiment are now missing.
We’re working on a fix to get that resolved ASAP. The discrepancies will be fixed as a result
Will let you know when it’s up.
is it a known issue that dark mode is not working if you reload the app iframe?
Works for me on Chrome in Windows.
@RaimisJ I’m happy to confirm that we’ve deployed a fix for the discrepancy issue. The dark mode colors in Connect should now match the ones in Jira, as they did before.
Hey @lexek-92 a new version of the JQL-editor (
2.0.0
) should now be available on NPM.
Please reach out if you find anything else. Cheers!
Thanks, looks good. There’s a little discrepancy with versions of @emotion
dependencies, but it can be overriden via package manager to ^11.0.0 without any issues:
"@emotion/react": "^11.7.1",
"@emotion/styled": "^10.0.7",
I also can’t find any documentation for border radius tokens, is it available somewhere?
Just a quick followup:
We managed to fix the large dark mode dialog background with the help of this blog article. The resolution was to not set a background color on the html body and also this:
To quote the quote in the linked blog article:
If the color scheme of an iframe differs from embedding document, iframe gets an opaque canvas background appropriate to its color scheme.
Which resulted in the entire iframe getting a solid background.
The exact same CSS (color-scheme: dark
) also fixed white scrollbars on the iframe html
element for us with dark theme in Connect dialogs in Chromium browsers
Hi @DanielDelCore , @stephenmok ,
For our automated tests we are using Jira Cloud which is under “Developer-First Rollouts program”. As of 2023-06-23 2:00 UTC, due to the appended initialColorMode=dark/light query parameter to connect iframe urls, our apps started getting “Authentication failed: query hash does not match.” errors. The query parameter is always added except in original theme. This means that our apps only works if and only if original theme is selected. Is there any change on Jira while generating the query hash or was the initialColorMode query parameter introduced recently?
Issue did not happen again after 2023-06-23 05:30 UTC. The initialColorMode query parameter is not being appended to the connect iframe url anymore.
Hi @mehmetaydogdu, we were able to mitigate the issue by rolling back one of our feature flags. Thanks for letting us know!
The exact same CSS (
color-scheme: dark
) also fixed white scrollbars on the iframehtml
element for us with dark theme in Connect dialogs in Chromium browsers
We recently updated our themes to include color-scheme
properties so this should no longer be necessary once this version of tokens rolls out to production:
@DanielDelCore I assume this update is for AtlasKit users? We don’t use AtlasKit but AUI.
Hey @BenRomberg, regardless if you’re using AUI or Atlaskit, the same theme css will be applied after calling initializeTheming
since it injects the CSS into your app. So it should work for you as well unless AUI is applying color-scheme: light
with higher specificity could you double check for me?
Hey @DanielDelCore, indeed it gets injected and we no longer need to specify it ourselves. Thanks for the hint
Is this already rolled out to 100% of tenants on both Jira and Confluence?
Hi @DanielDelCore, do you know if border radius tokens are documented somewhere?
@DanielDelCore another question that came up in our internal testing: While the connect iframes are being loaded, they have a white background, no matter which theme is selected.
Any chance this can be fixed for dark theme? See also ECOHELP-21329 for more details.
I’m facing the same issue! Any news regarding this @JulianLundman ?
Any news on this @BenRomberg ?
We’re still discussing the issue with Atlassian.