ADG3 vs AtlasKit

Maarten 2017-08-16 10:29:22 UTC #1

Hi everyone,

There are some differences between the design guidelines and AtlasKit components. I know it's a work in progress, so this is expected. But which one of the two is the most recent version?

Take lozenges for example. This is what lozenges look like in the design guidelines:

And this is what they look like in AtlasKit:

https://atlaskit.atlassian.com/components/lozenge

Is one more up-to-date than the other? And which one would that be?

Thank you,
Maarten

bgummer 2017-08-16 16:30:13 UTC #2

Hi @Maarten thanks for raising this. In general the source of truth is the ADG 3 guidelines, which AtlasKit then implements. I've messaged the ADG 3 team to double check this, and will comment back here soon. If it turns out that AtlasKit's lozenge component needs to be updated, you'll be able to get the fix (once it's ready) by updating the @atlaskit/lozenge component version in your project.

Thanks
Ben

bgummer 2017-08-17 17:06:27 UTC #3

Hi again @Maarten yes it looks like the AtlasKit component needs to be updated to match the latest ADG 3 lozenge design spec. It's not scheduled at the moment but it'll be mentioned in the component release notes (available on https://atlaskit.atlassian.com component pages) when it happens.

Cheers
Ben

Maarten 2017-08-30 09:48:15 UTC #4

Thanks Ben, I'll use the ADG 3 guidelines as my source of truth then.

Cheers
Maarten

ksnow 2017-09-17 15:41:40 UTC #5

Hey @Maarten , as AtlasKit catches up to ADG3 guidelines, something to consider is the development effort to match the guidelines. A one-off adjustment to AK component to look like the guidelines incurs overhead and future adjustment when AK catches up. I've taken the strategy of going with AK components to save the team effort of updating later. There are a few cases where we've had to roll our own because the component wasn't the right fit for our use case.

Maarten 2017-10-11 10:30:35 UTC #6

I definitely agree @ksnow. Unfortunately, the ADG3 Sketch file that Atlassian provided is missing a lot of components. So I'm recreating a lot of these components based on what I see in ADG 3 and AtlasKit.

I have designed a number of pages using components that turned out to be old and/or changed. The new look of the components didn't match with what we had in mind, so we had to change the design after learning about this.

But I'm using ADG 3 as the main source of truth now.

ksnow 2017-10-12 22:47:11 UTC #7

i feel your pain!!

david.garcia 2017-10-16 07:15:04 UTC #8

I'm in the same situation @Maarten, I'm using the Sketch files (which are awesome, but out of date) and I needed the new ones (sadpanda)

Maarten 2017-10-16 12:52:39 UTC #9

Should we let you know about components that don't match with ADG3?

The single-select component, for example, is much lighter than ADG3 tells us it should be. On some (non-calibrated) screens, we can't even see the background of the component.

ksnow 2017-10-20 22:03:42 UTC #10

yes, this is really helpful. i can file a bug for items you find.