Modal always full screen in Compass

Was working on my Compass app and noticed that the Modal is no longer shown as documented here

Instead is forces a fullscreen view like this:

This is the UI code:

<ModalTransition>
    {isOpen && (
        <Modal onClose={closeModal}>
            <ModalHeader>
                <ModalTitle>Link a Jenkins job</ModalTitle>
            </ModalHeader>
            <ModalBody>
                <Box xcss={{marginBottom: "space.075"}}>
                    <Label labelFor="search">Search</Label>
                    <Select
                        id="jobId"
                        options={options}
                        isLoading={isLoading}
                        isSearchable={true}
                        onInputChange={onSearch}
                        onChange={(e) => {
                            setJob(e.job);
                        }}
                        placeholder="Choose a job."
                    />
                    {typeof message && message.length > 0 && (
                        <SectionMessage appearance="error">{message}</SectionMessage>
                    )}
                </Box>
            </ModalBody>
            <ModalFooter>
                <LoadingButton isLoading={isAdding} appearance="primary" onClick={addJob}>Add Job</LoadingButton>
                <Button appearance="subtle" onClick={closeModal}>Close</Button>
            </ModalFooter>
        </Modal>
    )}
</ModalTransition>

Setting the width, or height properties of the Modal element have no impact on how the modal is shown.
I also tried updating teh @forge/react dependency but with the same full screen effect.

My Confluence and Jira don’t seem effected.

Where there any Force UI changes I missed for Compass??

2 Likes

Same here and can even confirm that for multiple apps. That looks awful :confused: Seems like they messed up something. I’m in the process of creating a support ticket.

God to know that it is not just me, I’ll also create a support ticket, hopefully they will pick it up quicker when multiple people report it.

On a side note, @mpaisley Can you chime in on this one?

Downgrading to “@atlaskit/modal-dialog”: “^13.4.0” seems to fix the size on my custom UI.

They migrated to @compiled/react in 14, and that seems to break the order in which CSS rules apply.

How did you do that downgrade @SilvreLestang

I tried adding "@atlaskit/modal-dialog": "^13.4.0" to the "dependencies" and to the "overrides" sections of the package.json but still have the fullscreen dialog.

Can you share a code snippet?

In the mean time Support has reproduced the issue and its being worked on now.

I didn’t see that you were using UI kit. In my case, I am using custom UI, so I can choose the version of @atlaskit/modal-dialog that I want. That is not possible, as far as I know, with UI kit.

Do you have any public ticket to share ?

Aha okay that makes sense then.

My support ticket, ECOHELP-61430, is not open, but I can add you if you like.

There indeed is a transitive dependency from @forge/react to @atlaskit/modal-dialog. But to be honest, I don’t think that it’s related to any dependency version we are using. At least in my case, we haven’t updated the apps in the past days on production and the problems still occurs (and I’m pretty sure this problem didn’t exist last Thursday/Friday).

I shared your findings in the support ticket, hopefully they will be able to resolve this shortly.

A fix was deployed that works on my instance

2 Likes