What is the future of deprecated methods of PageManager, SpaceManager etc.?

Confluence Development Confluence Data Center
1

While working on Confluence 9 compatibility, we noticed (again) that many methods like PageManager.getPage(long contentId) or SpaceManager.getSpace(String spaceKey) are deprecated (and have been for quite some time).

In many of our apps, we rely quite heavily on those methods (also from other, comparable Managers). The methods from services like ContentService.find are no real alternative for us, because, first, as far as we know, they take the permissions of the current user into account, and second, they return objects from the package com.atlassian.confluence.api.model that lack functionality.

We did not see any mention of this part of the API in any Confluence 10 announcement.
Can any official from Atlassian tell us if it safe to keep using those managers in the foreseeable future?

2 Likes
2

Any reply from Atlassian on this?

3

Do you have some information, @kmacleod?

4

Or maybe @Kusal?

5

We’re also curious if anyone at Atlassian has any updates on whether it’s safe to keep using these methods moving forward. We’re also looking for guidance on how to handle the shortcomings of ContentService and recommendations to replace the deprecated services.
@kmacleod @Kusal @VasylynaBurger

6

There are currently no plans to delete PageManager#getPage or SpaceManager#getSpace.

3 Likes
7

We are having trouble with pageManager.getPage ..we are getting an exception if a blogpost id is passed to it instead of a page id. According to javadocs it should return null in that case. But we get this:

org.springframework.orm.hibernate5.HibernateObjectRetrievalFailureException: Object [id=4673634456] was not of the specified subclass [com.atlassian.confluence.pages.Page] : loaded object was of wrong class class com.atlassian.confluence.pages.BlogPost

We are trying to find a draft with the id from the editor:

public ContentEntityObject getDraft(long draftId) {
        if (isSharedDraftsModeEnabled(null)) {
            Page draftPage = pageManager.getPage(draftId);
            return (draftPage != null && draftPage.isDraft() ? draftPage : null);
        }
        return draftManager.getDraft(draftId);
    }

Unfortunately it fails with the above exception right now. I tried to replace it by

contentService.find().withStatus(ContentStatus.DRAFT).withId(ContentId.deserialise(Long.toString(draftId)))
                            .fetchOrNull();

But it always returns null. I kindly ask to either provide a fix for the page manager or to help with a workaround. Thanks

8

Do you know if this change in behaviour occurred in 10.0?

9

Unfortunately, I can’t tell you because we are still implementing the changes announced for Confluence 10. But I know that it was definitely working on Confluence 8.0.0, but not on >= Confluence 9.2.1 anymore. I have added my observations in the ticket below, because the exception is very similar.

What can be done about it?

10

As a workaround, could you catch the exception for now?

11

yes, of course, but I believe it would be good to fix it on your site or to at least change the javadocs. Is there a replacement API for that? How can I get the drafts by using the content service?